[webkit-reviews] review denied: [Bug 109686] [chromium] move pixel generation logic to TestRunner library : [Attachment 188131] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied jochen at chromium.org's request
for review:
Bug 109686: [chromium] move pixel generation logic to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109686

Attachment 188131: Patch
https://bugs.webkit.org/attachment.cgi?id=188131&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188131&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:188
> +    std::auto_ptr<SkCanvas> m_canvas;

This isn't right - SkCanvas is SkRefCnt'd, so you need to use the skia
refcounting APIs to control ownership.