[webkit-reviews] review granted: [Bug 109700] [chromium] fix TestRunner build with enable_webrtc=0 : [Attachment 188084] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 10:34:47 PST 2013


Tony Chang <tony at chromium.org> has granted jochen at chromium.org's request for
review:
Bug 109700: [chromium] fix TestRunner build with enable_webrtc=0
https://bugs.webkit.org/show_bug.cgi?id=109700

Attachment 188084: Patch
https://bugs.webkit.org/attachment.cgi?id=188084&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188084&action=review


>
Tools/DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cp
p:33
> +#if defined(ENABLE_WEBRTC)

Why is some of this defined(ENABLE_WEBRTC) and some ENABLE_WEBRTC?
Should we #define ENABLE in config.h?


More information about the webkit-reviews mailing list