[webkit-reviews] review granted: [Bug 109100] [CSS Grid Layout] Adding or removing grid items doesn't properly recompute the track sizes : [Attachment 187719] Updated patch per discussion with Ojan: Always force a layout in minContentForChild / maxContentForChild.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 109100: [CSS Grid Layout] Adding or removing grid items doesn't properly
recompute the track sizes
https://bugs.webkit.org/show_bug.cgi?id=109100

Attachment 187719: Updated patch per discussion with Ojan: Always force a
layout in minContentForChild / maxContentForChild.
https://bugs.webkit.org/attachment.cgi?id=187719&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187719&action=review


r=me with the stray FIXME removed.

>>> Source/WebCore/rendering/RenderGrid.cpp:297
>>> +	     child->setNeedsLayout(true, MarkOnlyThis);
>> 
>> I don't think we need this bit actually. child->layout() should
unconditionally do the layout, no?
> 
> No, child->layout() will ASSERT if child doesn't need layout (see e.g.
RenderBlock::layout) as you shouldn't be calling layout on a renderer that
doesn't need it.
> 
> This part of the change is required and matches what other renderers are
doing to force a relayout on their children.

I see. I wonder how much value we get out of that assert. Seems sort of silly.