[webkit-reviews] review denied: [Bug 109011] File upload control doesn't apply CSS vertical padding or border to file name : [Attachment 187807] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Nils Barth <nbarth at chromium.org>'s
request for review:
Bug 109011: File upload control doesn't apply CSS vertical padding or border to
file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Attachment 187807: Patch
https://bugs.webkit.org/attachment.cgi?id=187807&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187807&action=review


r- because of test failure on Mac.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:106
> -    
> +

nit: Don't change unrelated lines.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:149
> -	   
> +

Ditto.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:152
> -	   
> +

Ditto.

> LayoutTests/fast/forms/file/file-input-padding-border-2.html:17
> +    .pad-all { padding: 10px; }
> +    .pad-left { padding-left: 10px; }
> +    .pad-right { padding-right: 10px; }
> +    .pad-top { padding-top: 10px; }
> +    .pad-bottom { padding-bottom: 10px; }
> +    .bor-all { border: 10px solid DarkGray; }
> +    .bor-left { border-left: 10px solid DarkGray; }
> +    .bor-right { border-right: 10px solid DarkGray; }
> +    .bor-top { border-top: 10px solid DarkGray; }
> +    .bor-bottom { border-bottom: 10px solid DarkGray; }

You fix a bug about padding-top and border-top. So you don't need to test
padding-left/right/bottom and border-left/right/bottom in this patch.