[webkit-reviews] review denied: [Bug 109316] REGRESSION: A page can be scrolled with touch when its body has style overflow-x:hidden or overflow-y:hidden : [Attachment 187930] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 109316: REGRESSION: A page can be scrolled with touch when its body has
style overflow-x:hidden or overflow-y:hidden
https://bugs.webkit.org/show_bug.cgi?id=109316

Attachment 187930: Patch
https://bugs.webkit.org/attachment.cgi?id=187930&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  I spoke with Jamesr and we learned a few things.

1.  Wheel events seem to scroll each direction separately, gestures may need to
do the same if they aren't already.
2.  This appears to be a programatic scroll path.  You really want to be
heading down the user-scroll paths instead. 
RenderBox::scroll/RenderLayer::scroll/ScrollableArea::scroll are the ones you
want.
3.  In the wheel-event case, scrolls are prevented for overflow: none by
ScrollableArea::scroll detecting that it doesn't have a scrollbar in the
direction you're asking it to scroll and bailing.  Gestures should likely go
down that same path.