[webkit-reviews] review granted: [Bug 109459] [iOS] Upstream changes to Platform.h : [Attachment 187610] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 13:17:01 PST 2013


Benjamin Poulain <benjamin at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 109459: [iOS] Upstream changes to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=109459

Attachment 187610: Patch v1
https://bugs.webkit.org/attachment.cgi?id=187610&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187610&action=review


> Source/WTF/wtf/Platform.h:624
>  

Remove the blank line.

> Source/WTF/wtf/Platform.h:627
> +#define ENABLE_JIT 1
> +#define ENABLE_LLINT 1
> +#define ENABLE_YARR_JIT 1

Move those 3 ENABLE with the ones above?

> Source/WTF/wtf/Platform.h:1131
> +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000 ||
PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080

I'd just add parenthesis here for readability.


More information about the webkit-reviews mailing list