[webkit-reviews] review granted: [Bug 107942] [texmap] Implement frames-per-second debug counter : [Attachment 187636] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 107942: [texmap] Implement frames-per-second debug counter
https://bugs.webkit.org/show_bug.cgi?id=107942

Attachment 187636: Patch
https://bugs.webkit.org/attachment.cgi?id=187636&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187636&action=review


LGTM with nitpicks.

> Source/WebCore/ChangeLog:9
> +	   where <interval> means the period in seconds (i.e. =1.5) between FPS


means -> is

> Source/WebCore/ChangeLog:10
> +	   updates on screen. It is measured by counting CGScene::paintTo*
calls

CGScene -> CoordinatedGraphicsScene

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cp
p:718
> +    const double delta = WTF::currentTime() - m_fpsTimestamp;

No need for const