[webkit-reviews] review denied: [Bug 109189] [Chromium] OpaqueRectTrackingContentLayerDelegateTest.cpp: define PaintCallback::operator() : [Attachment 187102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 22:31:05 PST 2013


Nico Weber <thakis at chromium.org> has denied Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 109189: [Chromium] OpaqueRectTrackingContentLayerDelegateTest.cpp: define
PaintCallback::operator()
https://bugs.webkit.org/show_bug.cgi?id=109189

Attachment 187102: Patch
https://bugs.webkit.org/attachment.cgi?id=187102&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
Look, I can now r-!

The changelog entry needs work. This is a bug in clang, which was fixed in
r174584. Since pure virtual destructors are very rare, I think it's ok to land
this as a workaround because the last roll happened so long ago, but it needs a
comment explaining why it's there (it looks very strange – maybe make the
function not pure as a workaround instead), and we need to undo this after the
next roll.


More information about the webkit-reviews mailing list