[webkit-reviews] review denied: [Bug 109345] Create the SharedGraphicsContext3D through its own method. : [Attachment 187414] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 22:09:32 PST 2013


James Robinson <jamesr at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 109345: Create the SharedGraphicsContext3D through its own method.
https://bugs.webkit.org/show_bug.cgi?id=109345

Attachment 187414: Patch
https://bugs.webkit.org/attachment.cgi?id=187414&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187414&action=review


> Source/WebCore/platform/graphics/GraphicsContext3D.h:491
> +    static PassRefPtr<GraphicsContext3D> createSharedContext();

I think it would be better to provide chromium-specific implementations of
SharedGraphicsContext3D functions and not modify the GraphicsContext3D
interface itself


More information about the webkit-reviews mailing list