[webkit-reviews] review denied: [Bug 70634] Mark GraphicsLayers as opaque when possible : [Attachment 186713] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 70634: Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Attachment 186713: Patch
https://bugs.webkit.org/attachment.cgi?id=186713&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=186713&action=review


> Source/WebCore/rendering/RenderLayer.cpp:5124
> +	   || listContentsOpaqueInRect(m_posZOrderList.get(), localRect)
> +	   || listContentsOpaqueInRect(m_negZOrderList.get(), localRect)
> +	   || listContentsOpaqueInRect(m_normalFlowList.get(), localRect);

These should use the accessors (posZOrderList() etc), which will assert if the
lists are stale.

> Source/WebCore/rendering/RenderLayer.cpp:5139
> +	   childLayer->convertToLayerCoords(this, childOffset);

convertToLayerCoords() doesn't handle transforms, so it's a bit weird to always
use it to convert the rect, then rely on the fact that contentsOpaqueInRect()
bails if there's a transform.