[webkit-reviews] review denied: [Bug 99239] NamedFlowCollection should be a ContextDestructionObserver : [Attachment 187076] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Hanyee Kim <choco at company100.net>'s
request for review:
Bug 99239: NamedFlowCollection should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=99239

Attachment 187076: Patch
https://bugs.webkit.org/attachment.cgi?id=187076&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187076&action=review


> Source/WebCore/dom/NamedFlowCollection.cpp:43
>  NamedFlowCollection::NamedFlowCollection(Document* doc)

doc -> document

> Source/WebCore/dom/NamedFlowCollection.cpp:45
> +    , m_document(doc)

You don't need the m_document variable anymore.  ContextDestructionObserver
already keep that information for you.

> Source/WebCore/dom/NamedFlowCollection.cpp:107
> -void NamedFlowCollection::documentDestroyed()
> +void NamedFlowCollection::contextDestroyed()
>  {
>      m_document = 0;
>  }

Once you remove m_document, you can delete this function.