[webkit-reviews] review requested: [Bug 108969] formenctype to have empty string as default value. : [Attachment 186714] updated_patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 15:02:09 PST 2013


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 108969: formenctype to have empty string as default value.
https://bugs.webkit.org/show_bug.cgi?id=108969

Attachment 186714: updated_patch
https://bugs.webkit.org/attachment.cgi?id=186714&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
(In reply to comment #2)
> (From update of attachment 186684 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=186684&action=review
> 
> > LayoutTests/fast/forms/submit-form-attributes.html:23
> >  input.setAttribute('formAction', 'http://localhost');
> > -shouldBe('input.formAction', '"http://localhost/"');
> > +shouldBeEqualToString("input.formAction", "http://localhost/");
> >  input.setAttribute('formAction', 'http://localhost/');
> 
> It seems the primary quote mark in this file is single quote.  Please use
consistent quote marks.

Updated test to use single quote as primary quote mark.
Thank you tkent for review comments.


More information about the webkit-reviews mailing list