[webkit-reviews] review granted: [Bug 108835] Optimize GlyphPage for case where all glyphs are available in the same font. : [Attachment 186710] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 14:55:03 PST 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 108835: Optimize GlyphPage for case where all glyphs are available in the
same font.
https://bugs.webkit.org/show_bug.cgi?id=108835

Attachment 186710: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=186710&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=186710&action=review


> Source/WebCore/platform/graphics/GlyphPage.h:191
> +	   : m_fontDataForAllGlyphs(undefinedFontDataValue())

This may be a stupid question but why can't this just be null?


More information about the webkit-reviews mailing list