[webkit-reviews] review denied: [Bug 107840] Add smartInsertDeleteEnabled setting to WebCore::Page : [Attachment 185048] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 107840: Add smartInsertDeleteEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=107840

Attachment 185048: Patch
https://bugs.webkit.org/attachment.cgi?id=185048&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Looks like this breaks initial value of the setting on Mac. We used to get it
from "WebSmartInsertDeleteEnabled" user default in
TextChecker::isSmartInsertDeleteEnabled(), and pass on process creation. Now,
looks like every client has to call WKPreferencesSetSmartInsertDeleteEnabled().


Even worse, if WKPreferencesSetSmartInsertDeleteEnabled() gets called by the
client, it is a no-op because of an early return:

void WebPageProxy::setSmartInsertDeleteEnabled(bool isSmartInsertDeleteEnabled)

{
    if (m_isSmartInsertDeleteEnabled == isSmartInsertDeleteEnabled)
	return;

So, this means that WKPreferencesSetSmartInsertDeleteEnabled(false) will have
no effect on Mac if WebSmartInsertDeleteEnabled was set to NO.

r- because of this. Please feel free to reset the review flag if I
misunderstood the code.