[webkit-reviews] review granted: [Bug 123458] [GTK] Put cache files in XDG_CACHE_HOME : [Attachment 219740] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 123458: [GTK] Put cache files in XDG_CACHE_HOME
https://bugs.webkit.org/show_bug.cgi?id=123458

Attachment 219740: Patch
https://bugs.webkit.org/attachment.cgi?id=219740&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219740&action=review


Looks good, but a few small suggestions before landing this. You can just
upload a new version with the Reviewed by line filled in and then I can commit
it with the commit queue.

> Source/WebKit/gtk/ChangeLog:3
> +	   https://bugs.webkit.org/show_bug.cgi?id=123458

This changelog is missing a newline.

> Source/WebKit2/ChangeLog:3
> +	   [GTK] Put cache files in XDG_CACHE_HOME
> +	   https://bugs.webkit.org/show_bug.cgi?id=123458

This one too.

> Tools/GtkLauncher/main.c:242
> -    iconDatabasePath = g_build_filename(g_get_user_data_dir(), "webkit",
"icondatabase", NULL);
> +    iconDatabasePath = g_build_filename(g_get_user_cache_dir(), "webkit",
"icondatabase", NULL);

It's probably a good moment to actually put this into a GtkLauncher
subdirectory instead of "webkit"