[webkit-reviews] review granted: [Bug 45994] XMLHttpRequest: status, statusText, getResponseHeader() and getAllResponseHeaders() throw DOM Exception 11 when the state is UNSENT or OPENED. : [Attachment 216116] Merges the fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 45994: XMLHttpRequest: status, statusText, getResponseHeader() and
getAllResponseHeaders() throw DOM Exception 11 when the state is UNSENT or
OPENED.
https://bugs.webkit.org/show_bug.cgi?id=45994

Attachment 216116: Merges the fix
https://bugs.webkit.org/attachment.cgi?id=216116&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216116&action=review


> Source/WebCore/ChangeLog:3
> +	   XMLHttpRequest: status, statusText, getResponseHeader() and
getAllResponseHeaders() throw DOM Exception 11 when the state is UNSENT or
OPENED.

I don't understand what this patch does for getResponseHeader() and
getAllResponseHeaders().

Please explain in ChangeLog, or rename the bug and update the ChangeLog if
these are no longer part of what's being done in this bug.

Also, this change doesn't just change what's done when the state is UNSENT or
OPENED - it also changes what's done in error state.