[webkit-reviews] review denied: [Bug 125993] [GTK] The fullscreen API should be enabled by default : [Attachment 219741] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 125993: [GTK] The fullscreen API should be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=125993

Attachment 219741: Patch
https://bugs.webkit.org/attachment.cgi?id=219741&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219741&action=review


It sounds good to me, have this been discussed with Carlos, Phillippe or
Martin? =)

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:834
> +	       _("Whether the Mozilla style API should be enabled."),

Mozilla style? This should say the same thing as the other one, and have a
Since of 2.4 I believe. Would be good to have the gtk-doc documentation header
added here, I think.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:907
> +	       _("Whether to enable the Javascriipt Fullscreen API"),

Javascript has 2 i's here, let's fix that too =)