[webkit-reviews] review granted: [Bug 126002] [GTK] Some unit tests using web extensions fail when run alone : [Attachment 219668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 20 03:42:04 PST 2013


Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 126002: [GTK] Some unit tests using web extensions fail when run alone
https://bugs.webkit.org/show_bug.cgi?id=126002

Attachment 219668: Patch
https://bugs.webkit.org/attachment.cgi?id=219668&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Quite clean. You could drop the type from the constructor and infer it based on
which constructor gets selected (no URL => document loaded, URL => uri
changed), but I think I prefer the explicit one, it's more future proof too.


More information about the webkit-reviews mailing list