[webkit-reviews] review granted: [Bug 125746] [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/ : [Attachment 219265] [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 125746: [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/
https://bugs.webkit.org/show_bug.cgi?id=125746

Attachment 219265: [iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/
https://bugs.webkit.org/attachment.cgi?id=219265&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219265&action=review


r=me

> Source/WebKit/mac/Configurations/DebugRelease.xcconfig:33
> -MACOSX_DEPLOYMENT_TARGET_iphoneos = 10.5;
> -MACOSX_DEPLOYMENT_TARGET_iphonesimulator = 10.5;
> +MACOSX_DEPLOYMENT_TARGET_iphoneos = 10.6;
> +MACOSX_DEPLOYMENT_TARGET_iphonesimulator = 10.6;

Lies!

> Source/WebKit/mac/Configurations/Version.xcconfig:35
> -SYSTEM_VERSION_PREFIX_iphoneos = 6; // iPhone OS is most like SnowLeopard
currently.
> +SYSTEM_VERSION_PREFIX_iphoneos = 6; // iOS is most like SnowLeopard
currently.

More lies!

> Source/WebKit/mac/Configurations/WebKit.xcconfig:64
> -HEADER_SEARCH_PATHS =
$(WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH)
$(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders
$(WEBCORE_PRIVATE_HEADERS_DIR)/icu
"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKit" $(HEADER_SEARCH_PATHS);
> +HEADER_SEARCH_PATHS =
$(WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH)
$(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders
$(WEBCORE_PRIVATE_HEADERS_DIR)/icu
"${BUILT_PRODUCTS_DIR}/DerivedSources/WebKit"
"$(BUILT_PRODUCTS_DIR)/usr/local/include" $(HEADER_SEARCH_PATHS);

This typo exited in open source, but the curly brackets around
"${BUILT_PRODUCTS_DIR} " should be parenthesis instead "$(BUILT_PRODUCTS_DIR)".


> Source/WebKit/mac/History/WebBackForwardList.mm:110
>  + (void)initialize
>  {
> +#if !PLATFORM(IOS)
>      JSC::initializeThreading();
>      WTF::initializeMainThreadToProcessMainThread();
>      RunLoop::initializeMainRunLoop();
> +#endif

All code like this needs to turn into a runtime check eventually.  (Please file
a bug.)

> Source/WebKit/mac/WebView/WebFrame.mm:1751
> +// WebCoreFrameBridge methods used by iOS applications and frameworks

Oh. The. Horror.  WebCoreFrameBride is long gone.  :)