[webkit-reviews] review granted: [Bug 125811] FTL should be able to do call ICs : [Attachment 219689] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 125811: FTL should be able to do call ICs
https://bugs.webkit.org/show_bug.cgi?id=125811

Attachment 219689: the patch
https://bugs.webkit.org/attachment.cgi?id=219689&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219689&action=review


r=me

> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:145
> +    // Henceforth we make it look like we had called through a register
preservation wrapper.

I would say "the exiting function was called" instead of "we had called".

> Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44
> +    unsigned indexOf(GPRReg gpr) const; // Return UINT_MAX if not found.

"Returns".