[webkit-reviews] review denied: [Bug 115613] GraphicsLayers should be aware of rounded rect clipping : [Attachment 214240] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 115613: GraphicsLayers should be aware of rounded rect clipping
https://bugs.webkit.org/show_bug.cgi?id=115613

Attachment 214240: Patch
https://bugs.webkit.org/attachment.cgi?id=214240&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214240&action=review


> Source/WebCore/rendering/RenderLayerBacking.cpp:588
> +static RoundedRect getRoundedRectMask(const RenderBox& renderBox)

We don't normally use 'get' in a function that returns a value.

> Source/WebCore/rendering/RenderLayerBacking.cpp:712
> +    m_graphicsLayer->setContentsRoundedRectMask(roundedRectMask);

I think it would be better to avoid calling setContentsRoundedRectMask() unless
there really is a rounded mask to use.

> Source/WebCore/rendering/RenderLayerBacking.cpp:721
> +	   clipLayer->setChildrenRoundedRectMask(roundedRectMask);

Ditto.