[webkit-reviews] review granted: [Bug 99200] Add support for blendmode to Core Animation layer : [Attachment 214735] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 17 10:47:21 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Mihai Tica
<mitica at adobe.com>'s request for review:
Bug 99200: Add support for blendmode to Core Animation layer
https://bugs.webkit.org/show_bug.cgi?id=99200

Attachment 214735: Patch
https://bugs.webkit.org/attachment.cgi?id=214735&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214735&action=review


> Source/WebCore/ChangeLog:12
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Tests: css3/compositing/blend-mode-layers.html

This needs some text summarizing the changes in the patch.

> Source/WebCore/rendering/RenderLayerBacking.cpp:384
> +    if (hasAncestorClippingLayer())
> +	   ancestorClippingLayer()->setBlendMode(style->blendMode());
> +
> +    m_graphicsLayer->setBlendMode(style->blendMode());

Do you really want to set it on both here?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1061
> +	   // If the layer composited for other reasons than blending, it is no
longer needed to keep track if a child was blended

"keep track of whether a child"

> Source/WebCore/rendering/RenderLayerCompositor.h:85
> +    CompositingReasonRoot				       = 1 << 23,
> +    CompositingReasonBlending			       = 1 << 24

The web inspector exposes these to authors. You should file a follow-up to
ensure that the inspector shows blending as a layer creation reason.


More information about the webkit-reviews mailing list