[webkit-reviews] review granted: [Bug 116374] [GTK] [CMake] Build the plugin process against GTK+ 2 : [Attachment 219298] Patch fixing small dependency issue

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 116374: [GTK] [CMake] Build the plugin process against GTK+ 2
https://bugs.webkit.org/show_bug.cgi?id=116374

Attachment 219298: Patch fixing small dependency issue
https://bugs.webkit.org/attachment.cgi?id=219298&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219298&action=review


>>> Source/WebKit2/PlatformGTK.cmake:484
>>> +	 # process and WebKit2 only once instead of recompiling them for the
plugin process.
>> 
>> Maybe build them into an intermediate library that is linked by both?
> 
> I think that's the best solution. It requires removing the files from the
shared source list and then adding them to an intermediate library. It seemed a
bit too much for this patch, so I hope it can be tackled later.

Absolutely!