[webkit-reviews] review requested: [Bug 125854] [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing : [Attachment 219413] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 125854: [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=125854

Attachment 219413: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=219413&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Patch attached. As you can see, the main change is this bit in DRT:

 JSObjectRef AccessibilityUIElement::makeJSAccessibilityUIElement(JSContextRef
context, const AccessibilityUIElement& element)
 {
+    if (!element.platformUIElement())
+	 return nullptr;
+
     return JSObjectMake(context, AccessibilityUIElement::getJSClass(), new
AccessibilityUIElement(element));
 }

I understand that should be ok for the Mac too (for other platforms,
PlatformUIElement is a pointer, so I assume it will be ok), but would be great
to confirm that.

Also, I slightly modified two tests more (besides roles-exposed.html) to be
able to test the same things while avoiding the differences in the
accessibility hierarchy compared to ATK based ports. Hope that's fine as well.

Please review, thanks!