[webkit-reviews] review canceled: [Bug 125377] REGRESSION: 2x regression on Dromaeo DOM query tests : [Attachment 219145] Reverted unrelated whitespace changes

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 125377: REGRESSION: 2x regression on Dromaeo DOM query tests
https://bugs.webkit.org/show_bug.cgi?id=125377

Attachment 219145: Reverted unrelated whitespace changes
https://bugs.webkit.org/attachment.cgi?id=219145&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=219145&action=review


This patch is still wrong for this case:

document.foo = function () {};
function f() { return document.foo; }
for (var i = 0; i < 400; ++i) {
    if (i == 350) {
	var img = new Image();
	img.name = "foo";
	document.body.appendChild(img);
    }
    f(); // should be the image element for the last 50 runs.
}

>> Source/JavaScriptCore/runtime/VM.cpp:785
>> +	m_impurePropertyWatchpointSets.remove(result);
> 
> It is important to leave it in m_impurePropertyWatchpointSets while calling
fireAll? If not, we could use take here instead of find/remove.

That's a good point. Will do.