[webkit-reviews] review denied: [Bug 125670] SVG animatable bindings are improperly being generated with "fastGetAttribute" : [Attachment 219139] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 125670: SVG animatable bindings are improperly being generated with
"fastGetAttribute"
https://bugs.webkit.org/show_bug.cgi?id=125670

Attachment 219139: Patch
https://bugs.webkit.org/attachment.cgi?id=219139&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=219139&action=review


>> Source/WebCore/bindings/scripts/CodeGenerator.pm:578
>> +	    } elsif (($interfaceName =~ /SVGScriptElement/) &&
($attribute->signature->name =~ /type/)) {
> 
> I don't understand this one. The "type" attribute on SVGScriptElement is not
animatable in the specification (svg 1.1 or 2):
> http://www.w3.org/TR/SVG2/script.html#ScriptElementTypeAttribute
> 
> Also, the attribute type in our IDL is a simple DOMString, not a
SVGAnimatedString.

Patch in bug 125527 corrects things so that SVGScriptElement’s type attribute
is correctly identified as not animatable, so we should land that first, and
omit this change.