[webkit-reviews] review requested: [Bug 125168] [MIPS] Wrong register usage in LLInt op_catch. : [Attachment 218585] Fixed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 6 03:17:31 PST 2013


Balazs Kilvady <kilvadyb at homejinni.com> has asked  for review:
Bug 125168: [MIPS] Wrong register usage in LLInt op_catch.
https://bugs.webkit.org/show_bug.cgi?id=125168

Attachment 218585: Fixed patch. 
https://bugs.webkit.org/attachment.cgi?id=218585&action=review

------- Additional Comments from Balazs Kilvady <kilvadyb at homejinni.com>
Added PIC header (.cpload($t9)) to all the LLInt ops. With this we can avoid
filtering rutins by label name. The speed penalty is not serious by the
SunSpider and v8 tests (although they aren't ideal for LLInt measuring, I
think).
SunSpider: 5272.0ms -> 5295.0ms
v8: 18751.0ms -> 18893.0ms

With this patch the MIPS implementation has 0 regression in mozilla tests.


More information about the webkit-reviews mailing list