[webkit-reviews] review granted: [Bug 123015] [GStreamer] webkitwebaudiosrc element needs to emit stream-start, caps and segment events : [Attachment 218584] patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 123015: [GStreamer] webkitwebaudiosrc element needs to emit stream-start,
caps and segment events
https://bugs.webkit.org/show_bug.cgi?id=123015

Attachment 218584: patch
https://bugs.webkit.org/attachment.cgi?id=218584&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218584&action=review


> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:266

>  
> +    gst_segment_free(&priv->segment);
> +

It's probably a good idea to switch to a smart pointer here.