[webkit-reviews] review denied: [Bug 124986] Nix Upstream: Adding Nix MediaPlayer related files : [Attachment 218018] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 124986: Nix Upstream: Adding Nix MediaPlayer related files
https://bugs.webkit.org/show_bug.cgi?id=124986

Attachment 218018: Patch
https://bugs.webkit.org/attachment.cgi?id=218018&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218018&action=review


Let's see a second round after Eric's comments.

> Source/WebCore/platform/graphics/nix/MediaPlayerPrivateNix.cpp:38
> +    auto nixPlayer =
adoptPtr(Nix::Platform::current()->createMediaPlayer(nullptr));

Please don't use auto here. The type is not obvious at all when reading the
line.