[webkit-reviews] review denied: [Bug 124983] Nix Upstream: Adding MediaControlsNix to WebCore : [Attachment 218016] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 124983: Nix Upstream: Adding MediaControlsNix to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124983

Attachment 218016: Patch
https://bugs.webkit.org/attachment.cgi?id=218016&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218016&action=review


> Source/WebCore/html/shadow/MediaControlsNix.cpp:60
> +    return 0;

return nullptr.

> Source/WebCore/html/shadow/MediaControlsNix.cpp:145
> +    Page* page = document().page();
> +    if (!page)

if (!document().page())
    return

> Source/WebCore/html/shadow/MediaControlsNix.cpp:166
> +    double now = m_mediaController->currentTime();
> +    double duration = m_mediaController->duration();

This should be done _after_ the early return.

> Source/WebCore/html/shadow/MediaControlsNix.cpp:170
> +
> +    Page* page = document().page();
> +    if (!page)
> +	   return;

ditto

> Source/WebCore/html/shadow/MediaControlsNix.h:45
> +    void changedMute() OVERRIDE;

Missing virtual.