[webkit-reviews] review denied: [Bug 122868] Web Inspector: ES6: JavaScript syntax highlighting and recognition of for..of : [Attachment 218053] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Laszlo Vidacs
<lac at inf.u-szeged.hu>'s request for review:
Bug 122868: Web Inspector: ES6: JavaScript syntax highlighting and recognition
of for..of
https://bugs.webkit.org/show_bug.cgi?id=122868

Attachment 218053: Patch
https://bugs.webkit.org/attachment.cgi?id=218053&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218053&action=review


> Source/WebInspectorUI/Tools/PrettyPrinting/codemirror.js:5570
> -	 var result = /\-[^ \-?]|\?[^ !\'\"\),.\-\/:;\?\]\}]/.test(str.slice(i
- 1, i + 1));
> -	 return result;
> +	 return /\-[^ \-?]|\?[^ !\'\"\),.\-\/:;\?\]\}]/.test(str.slice(i - 1, i
+ 1));

This change breaks the jsmin.py script. It needs reverted. This is a local
change to CodeMirror we have until we fix it. Testing
copy-user-interface-resources.sh with COMBINE_INSPECTOR_RESOURCES = YES will
show what I mean.

> Source/WebInspectorUI/Tools/PrettyPrinting/codemirror.js:5583
> -	 var result =
/[~!#%&*)=+}\]|\"\.>,:;][({[<]|-[^\-?\.\u2010-\u201f\u2026]|\?[\w~`@#$%\^&*(_=+
{[|><]|…[\w~`@#$%\^&*(_=+{[><]/.test(str.slice(i - 1, i + 1));
> -	 return result;
> +	 return
/[~!#%&*)=+}\]\\|\"\.>,:;][({[<]|-[^\-?\.\u2010-\u201f\u2026]|\?[\w~`@#$%\^&*(_
=+{[|><]|…[\w~`@#$%\^&*(_=+{[><]/.test(str.slice(i - 1, i + 1));

Ditto.