[webkit-reviews] review granted: [Bug 125049] Add JavaScript style checker and teach checker.py about .js files : [Attachment 218130] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 125049: Add JavaScript style checker and teach checker.py about .js files
https://bugs.webkit.org/show_bug.cgi?id=125049

Attachment 218130: patch
https://bugs.webkit.org/attachment.cgi?id=218130&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218130&action=review


> Tools/Scripts/webkitpy/style/checker_unittest.py:484
> +	   # Check checker attributes on a typical input.
> +	   file_base = "foo"
> +	   file_extension = "css"
> +	   file_path = file_base + "." + file_extension
> +	   self.assert_checker_text(file_path)
> +	   checker = self.dispatch(file_path)
> +	   self.assertEqual(checker.handle_style_error,
> +			     self.mock_handle_style_error)
> +

There is no mention in the ChangeLog of handling .css files as text. It also
seems weird to put this test in "test_js_paths" and not a "test_css_paths".
Looks fine though.