[webkit-reviews] review denied: [Bug 120300] AX:Null pointer may be dereferenced. : [Attachment 209761] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Lukasz Gajowy
<l.gajowy at samsung.com>'s request for review:
Bug 120300: AX:Null pointer may be dereferenced.
https://bugs.webkit.org/show_bug.cgi?id=120300

Attachment 209761: Patch
https://bugs.webkit.org/attachment.cgi?id=209761&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209761&action=review


> Source/WebCore/accessibility/AXObjectCache.cpp:334
> +    // Will crash later when widget type is other than FrameView or
ScrollBar.

This comment should read something like -- "Catch the case if an (unsupported)
widget type is used. Only FrameView and ScrollBar are supported now."

> Source/WebCore/accessibility/AXObjectCache.cpp:335
> +    ASSERT(newObj);

we should also do a if (!newObject) return; here
the ASSERT will catch this problem in DEBUG, but not in release