[webkit-reviews] review denied: [Bug 114873] [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries : [Attachment 208066] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 114873: [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE
boundaries
https://bugs.webkit.org/show_bug.cgi?id=114873

Attachment 208066: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=208066&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208066&action=review


any layout tests available?

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:952
> +    // It's definitely a sentence boundary if there's nothing before.

shouldn't this method just be

return startOfSentence(pos) == pos;

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:961
> +static bool isSpaceBetweenRealSentences(const VisiblePosition& position)

the name for the method is a bit confusing. what is it trying to determine?