[webkit-reviews] review granted: [Bug 120127] Remove JSObject::propertyIsEnumerable : [Attachment 209290] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 120127: Remove JSObject::propertyIsEnumerable
https://bugs.webkit.org/show_bug.cgi?id=120127

Attachment 209290: Fix
https://bugs.webkit.org/attachment.cgi?id=209290&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209290&action=review


> Source/JavaScriptCore/ChangeLog:8
> +	   This method just a wart.

This sentence just a wart.

> Source/JavaScriptCore/ChangeLog:9
> +	   Unnecessary const-casting, unnecessary function call, and less code
if we remove.

This sentence would be less words if we remove.

> Source/JavaScriptCore/runtime/ObjectPrototype.cpp:188
> +    PropertyDescriptor descriptor;
> +    bool enumerable = thisObject->getOwnPropertyDescriptor(exec,
propertyName, descriptor) && descriptor.enumerable();
> +    return JSValue::encode(jsBoolean(enumerable));

This should should have a FIXME saying to use getOwnPropertySlot when it no
longer has the global object hack.