[webkit-reviews] review granted: [Bug 120123] [BlackBerry] Incorrect origin of indexOfTile in LayerTiler can cause unnecessary texture jobs and waste memory : [Attachment 209287] Patch

[bugzilla-daemon at webkit.org]

Yong Li <yong.li.webkit at outlook.com> has granted Jacky Jiang
<jkjiang at webkit.org>'s request for review:
Bug 120123: [BlackBerry] Incorrect origin of indexOfTile in LayerTiler can
cause unnecessary texture jobs and waste memory
https://bugs.webkit.org/show_bug.cgi?id=120123

Attachment 209287: Patch
https://bugs.webkit.org/attachment.cgi?id=209287&action=review

------- Additional Comments from Yong Li <yong.li.webkit at outlook.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209287&action=review


r+ based on Arvid's review. but please update the comments before committing.
BTW, "maxXMaxYCorner" is a little bit confusing, as it gives me a feeling that
the returned value is included in the rect.

> Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:257
> +	   last = indexOfTile(ceiledIntPoint(visibleRect.maxXMaxYCorner()) +
IntPoint(-1, -1)); // The origin should be the top left of the bottom right
pixel.

shouldn't "top left" be "upper left"?

> Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp:415
> +	   TileIndex last = indexOfTile(job.m_dirtyRect.maxXMaxYCorner() +
IntPoint(-1, -1)); // The origin should be the top left of the bottom right
pixel.

shouldn't "top left" be "upper left"?