[webkit-reviews] review granted: [Bug 118106] Web Inspector: AX: Add additional contextual labels for Error/Warnings/Logs that will be spoken for screen readers : [Attachment 208968] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted James Craig
<james at cookiecrook.com>'s request for review:
Bug 118106: Web Inspector: AX: Add additional contextual labels for
Error/Warnings/Logs that will be spoken for screen readers
https://bugs.webkit.org/show_bug.cgi?id=118106

Attachment 208968: patch
https://bugs.webkit.org/attachment.cgi?id=208968&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208968&action=review


Nice!

> Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:49
> +	   if (!element.getAttribute("data-labelprefix")) 

Nit: This check could be hasAttribute instead of getAttribute.