[webkit-reviews] review granted: [Bug 119536] Refactor highestEditableRoot to avoid a redundant call to rendererIsEditable : [Attachment 208971] Cleanup

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 119536: Refactor highestEditableRoot to avoid a redundant call to
rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=119536

Attachment 208971: Cleanup
https://bugs.webkit.org/attachment.cgi?id=208971&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208971&action=review


> Source/WebCore/WebCore.exp.in:-2255
> -__ZNK7WebCore4Node18rendererIsEditableENS0_13EditableLevelE

You can't do that.

> Source/WebCore/editing/htmlediting.cpp:116
>      Node* highestRoot = editableRootForPosition(position, editableType);

Rename to highestEditableRoot? rootEditableNode?