[webkit-reviews] review denied: [Bug 119797] grammar-markers.html and grammar-markers-hidpi.html pass even if element does not have grammar marker : [Attachment 208723] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 119797: grammar-markers.html and grammar-markers-hidpi.html pass even if
element does not have grammar marker
https://bugs.webkit.org/show_bug.cgi?id=119797

Attachment 208723: proposed patch
https://bugs.webkit.org/attachment.cgi?id=208723&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208723&action=review


> LayoutTests/editing/spelling/grammar-markers-hidpi.html:36
> +    if (hasMarker && window.testRunner)
> +	   testRunner.notifyDone();

Doesn’t make sense. If we never find the marker we still need to mark the test
done, otherwise we’ll hang until we time out. We should write out whether we
found the marker, not hang when we didn’t find it.