[webkit-reviews] review granted: [Bug 119064] Typed arrays should be rewritten : [Attachment 208703] and now, passing more tests than ever!

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted  review:
Bug 119064: Typed arrays should be rewritten
https://bugs.webkit.org/show_bug.cgi?id=119064

Attachment 208703: and now, passing more tests than ever!
https://bugs.webkit.org/attachment.cgi?id=208703&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208703&action=review


r+ with gtk fix merged in

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h:124

> +	   if (!result)
> +	       return JSValue::encode(jsUndefined());

Can we assert that there's an exception in flight here?

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:346
> +    if (!thisObject->canSetIndexQuickly(propertyName)) {
> +	   // Yes, really. Firefox returns without throwing anything if you
store beyond
> +	   // the bounds.

I believe this is actually spec behavior - a lot of the indexable dom types
have this sort of thing