[webkit-reviews] review requested: [Bug 119454] Reset scrollbars when frameview load is completed : [Attachment 208456] patch

[bugzilla-daemon at webkit.org]

Roger Fong <roger_fong at apple.com> has asked  for review:
Bug 119454: Reset scrollbars when frameview load is completed
https://bugs.webkit.org/show_bug.cgi?id=119454

Attachment 208456: patch
https://bugs.webkit.org/attachment.cgi?id=208456&action=review

------- Additional Comments from Roger Fong <roger_fong at apple.com>
Note this is a workaround:
In this patch we update the scrollbars after the frameview has finished loading
and only if there is a mismatch between the style of the scrollbar and the
actual scrollbar (whether or not they're custom)

An enhanced workedaround was proposed that I could in the FrameView::layout
method just check to see if the style and actual scrollbar matched and then
update scrollbars as necessary then. That would not only solve this
particularly delayed loading problem but also the problem of scrollbars not
updating after dynamically changing the scrollbar css.

However, doing this causes a lot of unforeseen issues with the ordering during
which layouts are called that seem to result in scrollbar updates being
disabled altogether, which ultimately causes the document to adopt the default
scrollbar modes (vertical: ALWAYS ON and horizontal: ALWAYS off, though the
scrollbars are in the correct style).

Given that this patch is simply a temporary work around (and thus will be
removed soon anyways), I think we should focus on just fixing the bug at hand
and not dealing with the dynamic css changing issue for now.