[webkit-reviews] review requested: [Bug 119636] dataLog dumpers for WebCore's basic geometry types : [Attachment 208452] take one
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 9 14:10:37 PDT 2013
Tim Horton <thorton at apple.com> has asked for review:
Bug 119636: dataLog dumpers for WebCore's basic geometry types
https://bugs.webkit.org/show_bug.cgi?id=119636
Attachment 208452: take one
https://bugs.webkit.org/attachment.cgi?id=208452&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
I'm somewhat tempted to put them all in one big implementation file
(GeometryFormatters? I have no idea) instead of spreading datalog stuff
throughout all these classes (especially because of IntPoint and IntSize
lacking implementation files causing PrintStream.h inclusion in their headers
-- but maybe PrintStream.h doesn't change often and that won't be a problem?).
More information about the webkit-reviews
mailing list