[webkit-reviews] review denied: [Bug 109350] Resource leak related to gstreamer and videos : [Attachment 208252] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 109350: Resource leak related to gstreamer and videos
https://bugs.webkit.org/show_bug.cgi?id=109350

Attachment 208252: Patch
https://bugs.webkit.org/attachment.cgi?id=208252&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208252&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:4183
> +    // Once an active DOM object has been stopped it can not be restarted,
so we can deallocate the media player now.
> +    m_player.clear();

This is unnecessary. Earlier in this method we called userCancelledLoad(),
which called clearMediaPlayer(), which called m_player.clear().