[webkit-reviews] review granted: [Bug 119575] Restoring use of StackIterator instead of Interpreter::getStacktrace() : [Attachment 208347] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 09:04:27 PDT 2013


Oliver Hunt <oliver at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 119575: Restoring use of StackIterator instead of
Interpreter::getStacktrace()
https://bugs.webkit.org/show_bug.cgi?id=119575

Attachment 208347: the patch
https://bugs.webkit.org/attachment.cgi?id=208347&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208347&action=review


> Source/JavaScriptCore/interpreter/Interpreter.h:229
> +	   static EncodedJSValue JSC_HOST_CALL
constructWithErrorConstructor(ExecState*);
> +	   static EncodedJSValue JSC_HOST_CALL
callErrorConstructor(ExecState*);
> +	   static EncodedJSValue JSC_HOST_CALL
constructWithNativeErrorConstructor(ExecState*);
> +	   static EncodedJSValue JSC_HOST_CALL
callNativeErrorConstructor(ExecState*);
> +

I like this, but it seems like this can be a separate patch, r+ for anding it
separately


More information about the webkit-reviews mailing list