[webkit-reviews] review requested: [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. : [Attachment 207984] Updated patch-3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 1 23:19:12 PDT 2013
Abhijeet Kandalkar <kandalkar.abhijeet58 at gmail.com> has asked for review:
Bug 117265: Spatial Navigation should avoid unwanted calculation while deciding
focus candidate.
https://bugs.webkit.org/show_bug.cgi?id=117265
Attachment 207984: Updated patch-3
https://bugs.webkit.org/attachment.cgi?id=207984&action=review
------- Additional Comments from Abhijeet Kandalkar
<kandalkar.abhijeet58 at gmail.com>
Additionally, why should the iframe itself be considered a focus candidate?
1. node->isKeyboardFocusable(event) if node is IFrame returns true.
2. If we have Iframes in html page then Navigation alogorithm considers it as
focusable element.
if (HTMLFrameOwnerElement* frameElement =
frameOwnerElement(focusCandidate)) {
// consider Iframe as container and search best candidate node in
Iframe(container).
}
More information about the webkit-reviews
mailing list