[webkit-reviews] review requested: [Bug 119411] Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for the Mac port : [Attachment 207985] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has asked  for review:
Bug 119411: Remove pageOverlayShouldApplyFadeWhenPainting() and adopt
composited fade for the Mac port
https://bugs.webkit.org/show_bug.cgi?id=119411

Attachment 207985: patch
https://bugs.webkit.org/attachment.cgi?id=207985&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
We also need to make WKBundlePageOverlayFractionFadedIn return 1 always, to
prevent clients from attempting to bake the fade opacity in.

And, make the find-in-page overlay not bake the opacity in as well.

In doing this I also removed PageOverlay::fractionFadedIn so nobody tries to
use it for anything (since it is not useful with composited fade, and will be
totally wrong with CA-accelerated fade).