[webkit-reviews] review granted: [Bug 116480] update import-w3c-tests to actually work : [Attachment 202336] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 116480: update import-w3c-tests to actually work
https://bugs.webkit.org/show_bug.cgi?id=116480

Attachment 202336: Patch
https://bugs.webkit.org/attachment.cgi?id=202336&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202336&action=review


> Tools/Scripts/webkitpy/w3c/test_importer.py:189
> +	       DIRS_TO_SKIP = ('.git', '.hg', 'data', 'archive')

I don't think this local variable is helpful; it should at least be spelled out
as DIRECTORIES_TO_SKIP but that's not really descriptive either.

> Tools/Scripts/webkitpy/w3c/test_importer.py:191
> +	       for d in DIRS_TO_SKIP:
> +		   if d in dirs:

Can we sell out directory?