[webkit-reviews] review granted: [Bug 118768] Remove a bunch of redundant checks for empty string in StringImpl : [Attachment 206850] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 118768: Remove a bunch of redundant checks for empty string in StringImpl
https://bugs.webkit.org/show_bug.cgi?id=118768

Attachment 206850: Patch
https://bugs.webkit.org/attachment.cgi?id=206850&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206850&action=review


> Source/WTF/wtf/text/StringImpl.cpp:416
>	   int32_t length = m_length;

Can we add an assertion that m_length is non-zero here?

> Source/WTF/wtf/text/StringImpl.cpp:448
>  

Ditto.