[webkit-reviews] review denied: [Bug 115285] [webkitpy] suggest-nominations doesn't count all qualified patches : [Attachment 200065] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Glenn Adams
<glenn at skynav.com>'s request for review:
Bug 115285: [webkitpy] suggest-nominations doesn't count all qualified patches
https://bugs.webkit.org/show_bug.cgi?id=115285

Attachment 200065: Patch
https://bugs.webkit.org/attachment.cgi?id=200065&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
I agree with Ryosuke here, I don't get _analyze_commits. Especially the last,
never used, argument.

If you need the function for future change, just add it with those changes.

I would also modify contributors.json separately from this patch.

> > This is the sole caller of _analyze_commits. We shouldn't need to make it
take two callbacks.
> > We don't any more premature/over generalization in webkitpy. It's bad as
is.
> 
> I disagree. There is a perfectly good reason to do this.

What is the good reason?
This is the kind of information best detailed in the ChangeLog.