[webkit-reviews] review granted: [Bug 114994] Plugin Snapshotting: Don't consume insane amounts of time detecting the primary plugin : [Attachment 199117] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 114994: Plugin Snapshotting: Don't consume insane amounts of time detecting
the primary plugin
https://bugs.webkit.org/show_bug.cgi?id=114994

Attachment 199117: patch
https://bugs.webkit.org/attachment.cgi?id=199117&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199117&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3949
> +void WebPage::determinePrimarySnapshottedPlugInTimerFired()
> +{
> +#if ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC)
> +    if (!m_page->settings()->snapshotAllPlugIns() &&
m_page->settings()->primaryPlugInSnapshotDetectionEnabled())
> +	   determinePrimarySnapshottedPlugIn();
> +#endif
> +}

You probably want to put the entire function body inside the #if.